fix(weave): exception field of call object not being set on get_calls

[zbirenbaum]

Description

• Fixes WB-23275

Fixes exception field being lost when iterating over calls returned by python client SDK.

Summary by CodeRabbit

• New Features
  • Enhanced error handling during client-server interactions by introducing an expanded mechanism to capture and relay additional error details, ensuring improved system robustness without impacting existing operations.

[circle-job-mirror]

Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=b3968b2cf16343a4608c13aa5637cf77287a6cb9

[coderabbitai]

Walkthrough

The pull request updates the make_client_call function in the weave/trace/weave_client.py file. An additional parameter, exception, is introduced and assigned from server_call.exception. This change expands the function's interface to include error handling without altering the existing logic or control flow.

Changes

File	Change Summary
weave/trace/weave_client.py	Added exception parameter to make_client_call, assigning it the value from server_call.exception.

Sequence Diagram(s)

sequenceDiagram
    participant C as Client
    participant F as make_client_call
    participant SC as ServerCall
    participant TS as TraceServerInterface

    C->>F: Call make_client_call(entity, project, server_call, server)
    F->>SC: Extract exception value
    F->>TS: Invoke server call with exception parameter
    TS-->>F: Return response or error
    F-->>C: Return final outcome

Loading

Suggested reviewers

• andrewtruong
• gtarpenning

Poem

I'm a bunny stepping through the code,
Hopping on lines where exceptions are bestowed.
New parameters spring like a fresh carrot treat,
Helping client calls feel quick and neat.
With a twitch of my nose, I celebrate this feat! 🐇🎉

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 401ff55 and 8453e42.

📒 Files selected for processing (1)

• weave/trace/weave_client.py (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.py`: Focus on pythonic code patterns. Check for proper...

**/*.py: Focus on pythonic code patterns.
Check for proper exception handling.
Verify type hints usage where applicable.
Look for potential performance improvements.
Don't comment on formatting if black/isort is configured.
Check for proper dependency injection patterns.
Verify proper async handling if applicable.

• weave/trace/weave_client.py

⏰ Context from checks skipped due to timeout of 90000ms (80)

• GitHub Check: Trace nox tests (3, 13, trace)
• GitHub Check: Trace nox tests (3, 12, scorers)
• GitHub Check: Trace nox tests (3, 12, trace)
• GitHub Check: Trace nox tests (3, 11, scorers)
• GitHub Check: Trace nox tests (3, 11, trace)
• GitHub Check: Trace nox tests (3, 10, scorers)
• GitHub Check: Trace nox tests (3, 10, trace)
• GitHub Check: Trace nox tests (3, 9, scorers)
• GitHub Check: Trace nox tests (3, 13, trace)
• GitHub Check: Trace nox tests (3, 12, scorers)
• GitHub Check: Trace nox tests (3, 12, trace)
• GitHub Check: Trace nox tests (3, 11, scorers)
• GitHub Check: Trace nox tests (3, 11, trace)
• GitHub Check: Trace nox tests (3, 10, scorers)
• GitHub Check: Trace nox tests (3, 10, trace)
• GitHub Check: Trace nox tests (3, 9, scorers)
• GitHub Check: Trace nox tests (3, 13, trace)
• GitHub Check: Trace nox tests (3, 12, scorers)
• GitHub Check: Trace nox tests (3, 12, trace)
• GitHub Check: Trace nox tests (3, 11, scorers)
• GitHub Check: Trace nox tests (3, 11, trace)
• GitHub Check: Trace nox tests (3, 10, scorers)
• GitHub Check: Trace nox tests (3, 10, trace)
• GitHub Check: Trace nox tests (3, 9, scorers)
• GitHub Check: Trace nox tests (3, 13, trace)
• GitHub Check: Trace nox tests (3, 12, scorers)
• GitHub Check: Trace nox tests (3, 12, trace)
• GitHub Check: Trace nox tests (3, 11, scorers)
• GitHub Check: Trace nox tests (3, 11, trace)
• GitHub Check: Trace nox tests (3, 10, scorers)
• GitHub Check: Trace nox tests (3, 10, trace)
• GitHub Check: Trace nox tests (3, 9, scorers)
• GitHub Check: Trace nox tests (3, 13, trace)
• GitHub Check: Trace nox tests (3, 12, scorers)
• GitHub Check: Trace nox tests (3, 12, trace)
• GitHub Check: Trace nox tests (3, 11, scorers)
• GitHub Check: Trace nox tests (3, 11, trace)
• GitHub Check: Trace nox tests (3, 10, scorers)
• GitHub Check: Trace nox tests (3, 10, trace)
• GitHub Check: Trace nox tests (3, 9, scorers)
• GitHub Check: Trace nox tests (3, 13, trace)
• GitHub Check: Trace nox tests (3, 12, scorers)
• GitHub Check: Trace nox tests (3, 12, trace)
• GitHub Check: Trace nox tests (3, 11, scorers)
• GitHub Check: Trace nox tests (3, 11, trace)
• GitHub Check: Trace nox tests (3, 10, scorers)
• GitHub Check: Trace nox tests (3, 10, trace)
• GitHub Check: Trace nox tests (3, 9, scorers)
• GitHub Check: Trace nox tests (3, 13, trace)
• GitHub Check: Trace nox tests (3, 12, scorers)
• GitHub Check: Trace nox tests (3, 12, trace)
• GitHub Check: Trace nox tests (3, 11, scorers)
• GitHub Check: Trace nox tests (3, 11, trace)
• GitHub Check: Trace nox tests (3, 10, scorers)
• GitHub Check: Trace nox tests (3, 10, trace)
• GitHub Check: Trace nox tests (3, 9, scorers)
• GitHub Check: Trace nox tests (3, 13, trace)
• GitHub Check: Trace nox tests (3, 12, scorers)
• GitHub Check: Trace nox tests (3, 12, trace)
• GitHub Check: Trace nox tests (3, 11, scorers)
• GitHub Check: Trace nox tests (3, 11, trace)
• GitHub Check: Trace nox tests (3, 10, scorers)
• GitHub Check: Trace nox tests (3, 10, trace)
• GitHub Check: Trace nox tests (3, 9, scorers)
• GitHub Check: Trace nox tests (3, 13, trace)
• GitHub Check: Trace nox tests (3, 12, scorers)
• GitHub Check: Trace nox tests (3, 12, trace)
• GitHub Check: Trace nox tests (3, 11, scorers)
• GitHub Check: Trace nox tests (3, 11, trace)
• GitHub Check: Trace nox tests (3, 10, scorers)
• GitHub Check: Trace nox tests (3, 10, trace)
• GitHub Check: Trace nox tests (3, 9, scorers)
• GitHub Check: Trace nox tests (3, 13, trace)
• GitHub Check: Trace nox tests (3, 12, scorers)
• GitHub Check: Trace nox tests (3, 12, trace)
• GitHub Check: Trace nox tests (3, 11, scorers)
• GitHub Check: Trace nox tests (3, 11, trace)
• GitHub Check: Trace nox tests (3, 10, scorers)
• GitHub Check: Trace nox tests (3, 10, trace)
• GitHub Check: Trace nox tests (3, 9, scorers)

🔇 Additional comments (1)

weave/trace/weave_client.py (1)

736-736: Fixed exception field propagation in make_client_call.

This change correctly assigns the exception field from server_call to the Call constructor, which fixes the issue described in WB-23275 where the exception field was not being set during iteration over calls in the Python client SDK.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.