chore(app): UI improvements for runs history step slider #3780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes update the visual presentation of two components within the Panel module. In the Changes
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (896)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=b38824b562141e7cf2e9117f72f05d06efb988f6 |
nicholaspun-wandb
force-pushed
the
npun-step-slider-styling
branch
from
9cedfa4 to
2979b0f
Compare
| color: '#666', | ||
| fontSize: '14px', | ||
| }}> | ||
| No items to display |
There was a problem hiding this comment.
This is already an improvement over the existing behavior 👍
If the PanelTable is a Run History Step Slider, could we display a different message saying there's "no items to display for this step" and default to "No items to display" for all other table types?
There was a problem hiding this comment.
This is a bit finnicky ... I'm not using the PanelTable component directly, it's rendering via PanelComp2. I think there are instances where we directly render the final component (i.e. PanelTable) but it requires manually setting up the config and all. I'm gonna merge these simple changes in first and then I'll address the empty message in a different PR.
There was a problem hiding this comment.
Sounds good to me, thanks for looking into it!
domphan-wandb
approved these changes
Feb 26, 2025
nicholaspun-wandb
force-pushed
the
npun-step-slider-styling
branch
from
2979b0f to
982f688
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Old:
New:
Old:
New:
Testing
Local FE (See screenshots above)
Summary by CodeRabbit