Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): replace circle icon #3292

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

jamie-rasmussen
Copy link
Collaborator

Description

Continuing quest to only use our own icon library.

Note: our filled circle icon at its default size renders the circle slightly smaller than what we had with Material, going from 13.33x13.33 to 11.67x11.67. But I think this actually looks a bit better with the font size it accompanies.

Before:
Screenshot 2024-12-19 at 1 43 45 AM
Screenshot 2024-12-19 at 1 43 38 AM

After:
Screenshot 2024-12-19 at 1 42 44 AM
Screenshot 2024-12-19 at 1 42 58 AM

Testing

How was this PR tested?

@circle-job-mirror
Copy link

circle-job-mirror bot commented Dec 19, 2024

@jamie-rasmussen jamie-rasmussen marked this pull request as ready for review December 19, 2024 13:18
@jamie-rasmussen jamie-rasmussen requested review from a team as code owners December 19, 2024 13:18
@jamie-rasmussen jamie-rasmussen force-pushed the jamie/replace-circle-icon branch from 3b5a537 to 12e5ace Compare January 6, 2025 20:10
@jamie-rasmussen jamie-rasmussen merged commit 5a61b84 into master Jan 7, 2025
121 checks passed
@jamie-rasmussen jamie-rasmussen deleted the jamie/replace-circle-icon branch January 7, 2025 17:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants