feat(ui): delete objects from the ui #3261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tssweeney
reviewed
Jan 7, 2025
tssweeney
reviewed
Jan 7, 2025
weave-js/src/components/PagePanelComponents/Home/Browse3/pages/CallPage/ObjectViewer.tsx
Outdated
Show resolved
Hide resolved
weave-js/src/components/PagePanelComponents/Home/Browse3/pages/wfReactInterface/utilities.ts
Outdated
Show resolved
Hide resolved
| req: TraceObjDeleteReq | ||
| ): Promise<void | {detail: string}> { | ||
| const res = super.objectDelete(req).then(r => { | ||
| if (r && 'detail' in r) { |
There was a problem hiding this comment.
why throw only if there are details?
gtarpenning
commented
Jan 9, 2025
| @@ -25,7 +25,7 @@ export type EvaluationComparisonSummary = { | |||
|
|
|||
| // Models are the Weave Objects used to define the model logic and properties. | |||
| models: { | |||
| [modelRef: string]: ModelObj; | |||
There was a problem hiding this comment.
models can now be deleted!
gtarpenning
commented
Jan 9, 2025
Comment on lines
46
to
-50
| const evaluationCall = props.state.summary.evaluationCalls[props.callId]; | ||
| const modelObj = props.state.summary.models[evaluationCall.modelRef]; | ||
| const objRef = useMemo( | ||
| () => parseRef(modelObj.ref) as WeaveObjectRef, | ||
| [modelObj.ref] | ||
| ); |
There was a problem hiding this comment.
@tssweeney does this make sense? I think we actually never needed modelObj because we are only using it for its ref? Which I think is = to evaluationCall.modelRef but could be wrong...
gtarpenning
changed the title
gtarpenning
changed the title
tssweeney
approved these changes
Jan 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WB-22373
This pr adds support for handling deleted objects in the UI. Specifically:
strikedthroughTesting
Rendering a compare-eval page with a deleted model:
