Skip to content

Commit

Permalink
Fix playbook-create_delete_record_Test (demisto#38123)
Browse files Browse the repository at this point in the history
* Fix playbook-create_delete_record_Test

* add tests

* format

* Fix test playbook in integration

* RN
  • Loading branch information
MosheEichler authored Jan 23, 2025
1 parent 3ac0ce1 commit add46a4
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 14 deletions.
2 changes: 1 addition & 1 deletion Packs/AWS-Route53/Integrations/AWSRoute53/AWSRoute53.yml
Original file line number Diff line number Diff line change
Expand Up @@ -416,4 +416,4 @@ script:
subtype: python3
type: python
tests:
- No tests
- playbook-create_delete_record_Test
6 changes: 6 additions & 0 deletions Packs/AWS-Route53/ReleaseNotes/1_1_39.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@

#### Integrations

##### AWS - Route53

Documentation and metadata improvements.
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
id: playbook-create_delete_record_Test
version: 4
vcShouldKeepItemLegacyProdMachine: false
version: -1
name: playbook-create_delete_record_Test
description: Creation and deletion of AWS Route53 DNS record
description: Creation and deletion of AWS Route53 DNS record.
fromversion: 6.5.0
starttaskid: "0"
tasks:
Expand All @@ -16,6 +15,7 @@ tasks:
name: ""
iscommand: false
brand: ""
description: ''
nexttasks:
'#none#':
- "2"
Expand Down Expand Up @@ -43,8 +43,7 @@ tasks:
id: 4f3a8eb1-0073-4648-893a-8215f1fa4c6c
version: -1
name: Create DNS record within the hosted zone
description: Creates a resource record set. Creates a resource record set that
has the specified values.
description: Creates a resource record set. Creates a resource record set that has the specified values.
script: AWS - Route53|||aws-route53-create-record
type: regular
iscommand: true
Expand All @@ -54,7 +53,7 @@ tasks:
- "9"
scriptarguments:
hostedZoneId:
simple: ${AWS.Route53.HostedZones.Id}
simple: ${AWS.Route53.HostedZones.[0].Id}
source:
simple: ${dns_record_name}
target:
Expand Down Expand Up @@ -87,8 +86,7 @@ tasks:
id: 421a0b18-3414-42e2-8963-7570a7a80e34
version: -1
name: List hosted zones
description: 'Retrieves a list of the public and private hosted zones that are
associated with the current AWS account. '
description: Retrieves a list of the public and private hosted zones that are associated with the current AWS account.
script: AWS - Route53|||aws-route53-list-hosted-zones
type: regular
iscommand: true
Expand Down Expand Up @@ -159,8 +157,7 @@ tasks:
id: ef2f4e6f-6e00-44e3-8e77-c0df125be64a
version: -1
name: Delete the DNS record to cleanup after the playbook
description: Deletes a resource record set. Deletes an existing resource record
set that has the specified values.
description: Deletes a resource record set. Deletes an existing resource record set that has the specified values.
script: '|||aws-route53-delete-record'
type: regular
iscommand: true
Expand All @@ -170,7 +167,7 @@ tasks:
- "14"
scriptarguments:
hostedZoneId:
simple: ${AWS.Route53.HostedZones.Id}
simple: ${AWS.Route53.HostedZones.[0].Id}
source:
simple: ${dns_record_name}
target:
Expand Down Expand Up @@ -252,6 +249,7 @@ tasks:
type: title
iscommand: false
brand: ""
description: ''
separatecontext: false
continueonerrortype: ""
view: |-
Expand Down
2 changes: 1 addition & 1 deletion Packs/AWS-Route53/pack_metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "AWS - Route53",
"description": "Amazon Web Services Managed Cloud DNS Service.",
"support": "xsoar",
"currentVersion": "1.1.38",
"currentVersion": "1.1.39",
"author": "Cortex XSOAR",
"url": "https://www.paloaltonetworks.com/cortex",
"email": "",
Expand Down
3 changes: 2 additions & 1 deletion Tests/conf.json
Original file line number Diff line number Diff line change
Expand Up @@ -5803,7 +5803,8 @@
},
{
"integrations": "AWS - Route53",
"playbookID": "playbook-create_delete_record_Test"
"playbookID": "playbook-create_delete_record_Test",
"is_mockable": false
},
{
"integrations": "Cylance Protect v2",
Expand Down

0 comments on commit add46a4

Please sign in to comment.