Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message Received Despite Relay = false in Test TestMessageNotReceivedWithoutRelay #28

Open
AYAHASSAN287 opened this issue Feb 5, 2025 · 0 comments

Comments

@AYAHASSAN287
Copy link
Collaborator

Description:

When running the test TestMessageNotReceivedWithoutRelay, the test fails because the receiver node successfully receives the message even though both the sender and receiver nodes have Relay = false.

This behavior contradicts the expected outcome, where the message should not be propagated through the network when the relay functionality is disabled.


Steps to Reproduce:

  1. Run the following test case:
    go test -v -run ^TestMessageNotReceivedWithoutRelay$ ./testlibs/waku-go-tests
    

2.Observe the logs and test output.
3.Despite having Relay = false for both nodes, the message is still received, causing the test to fail.

** Expected Behavior:**

ReceiverNode should NOT receive the message when both nodes have Relay = false.
The test should pass if the message is not received.

Actual Behavior:

The receiver node receives the message, causing the test to fail unexpectedly.
This suggests that messages are being propagated even without the relay functionality enabled.

Test Failure Output:

 --- FAIL: TestMessageNotReceivedWithoutRelay (3.01s)
   test_no_relay_message.go:50: Test failed: ReceiverNode SHOULD NOT have received the message
   FAIL
   exit status 1
  FAIL    github.com/waku-org/waku-go-bindings/testlibs/waku-go-tests    3.015s


### **Possible Cause:**

The relay configuration (Relay = false) might not be properly enforced during node initialization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant