chore: filter remove all subscription from a peer that is leaving #3267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 908cd20 |
Ivansete-status
force-pushed
the
filter-peer-left-fix
branch
from
6854745 to
cab9cd7
Compare
NagyZoltanPeter
requested changes
Jan 31, 2025
NagyZoltanPeter
approved these changes
Jan 31, 2025
gabrielmer
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@fbarbu15 reported that
waku-interop-testsstarted to fail.The problem appeared when one filter-client completely disconnects, e.g., node shutdown. In this case, the
waku_filter_2/subscriptions.nimmodule was still keeping an incorrectConnectioninstance.waku/waku_filter_v2/protocol.nimstarts keeping track of the filter-client'sConnections inpeerConnections: Table[PeerId, Connection]waku/waku_filter_v2/protocol.nimadds a newConnectionwhen a new message needs to be pushed to filter-client.waku/waku_filter_v2/protocol.nimlistens to filter-client-peer disconnect events, in which case, the previousConnectionobject is dropped.Issue
closes: #3263
closes: #3254