feat: remain windows support #3162
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivansete-status
approved these changes
Dec 12, 2024
scripts/windows_setup.sh
Outdated
| echo "Building $name" | ||
| if [ -d "$dir" ]; then | ||
| change_directory "$dir" | ||
| execute_command "$command" | ||
| # Execute command but ignore errors containing 'upx' | ||
| if ! eval "$command" 2>&1 | tee /tmp/build.log; then | ||
| if grep -q "upx" /tmp/build.log; then |
There was a problem hiding this comment.
Should we remove the /tmp/build.log afterwards?
There was a problem hiding this comment.
Aplologize for late reply, it's temporary, and we will remove it eventually
darshankabariya
force-pushed
the
remain_windows_support
branch
from
15e3df3 to
04df684
Compare
|
You can find the image built from this PR at Built from fa58052 |
darshankabariya
force-pushed
the
remain_windows_support
branch
from
ec547ea to
d2e2f7f
Compare
darshankabariya
force-pushed
the
remain_windows_support
branch
from
cad6b4c to
bf703e9
Compare
darshankabariya
force-pushed
the
remain_windows_support
branch
from
bf703e9 to
122e0f3
Compare
darshankabariya
force-pushed
the
remain_windows_support
branch
from
e99af3b to
d6048bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will add all remain windows support with this PR