[v3] Allow adding OnClick to disabled MenuItem (macOS) #4089
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a problem reported in https://discord.com/channels/1042734330029547630/1341502426825494730/1341502426825494730, wherein it's not possible to set an
OnClick
for a menu item that starts out disabled.It's a draft mostly because I have no idea if the fix is correct, but I wanted to show an example of what is happening and a potential avenue to explore.
Fixes # NA
Type of change
Please select the option that is relevant.
How Has This Been Tested?
I added to the v3 example named
menu
. To test, start up the example, click the "Enable show window" option, then press the newly-enabled "Show window" menu item. Without the changes here, nothing happens. With them, the window appears.If you checked Linux, please specify the distro and version.
Test Configuration
Please paste the output of
wails doctor
. If you are unable to run this command, please describe your environment in as much detail as possible.Checklist:
website/src/pages/changelog.mdx
with details of this PR