Skip to content

Commit

Permalink
Merge pull request #11 from Emalcat/main
Browse files Browse the repository at this point in the history 
Fix Some Sound Effects Still In English
  • Loading branch information
@wagrenier
wagrenier authored Oct 26, 2023
2 parents 5882a39 + 8aad676 commit 7a79896
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Zero2UndubProcess/Importer/ZeroFileImporter.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public void RestoreGame()
{
_isoHandler.WriteNewFile(originFile, targetFile);

if (originFile.Type != FileType.AUDIO || originFile.Type != FileType.SOUNDEFFECT)
if (originFile.Type != FileType.AUDIO && originFile.Type != FileType.SOUNDEFFECT)
{
continue;
}
Expand Down

8 comments on commit 7a79896

@DarthMotzkus
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it gonna be compile in a new release version?

@wagrenier
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to do so, yes it will

@DarthMotzkus
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wagrenier thanks! I still can't pass from the first door after enter the first house on OPL internal hdd. Any clue to solve this?

@wagrenier
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/wagrenier/Zero2Undub/releases/tag/1.0.2

@wagrenier
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try this new release and see if it fixes it?

@DarthMotzkus
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wagrenier, I've tested here and only the Safe Mode pass the door and the game works normally after.
But still remains many english voice acting ingame... is there a patch on the way to improve this? Or is there no way to have it fully undub working via OPL?
I've burned a dvd disc too, with ESR patched .iso, and it seems to work properly, even it isn't the safe mode one.
But via OPL, on USB or Internal HDD, only the safe mode pass the first door, unfotunately with many english voice acting ingame remaining...
Thanks for the support!

@wagrenier
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you open an issue ticket weeill all the info and your save file please?

@DarthMotzkus
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure but i didn't save. It's just the first door, 2 min ingame to reach. Gonna open the issue soon, thanks.

Please sign in to comment.