Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more sensible bounds on certain timers #27

Open
seanshahkarami opened this issue Mar 13, 2017 · 0 comments
Open

Add more sensible bounds on certain timers #27

seanshahkarami opened this issue Mar 13, 2017 · 0 comments
Assignees

Comments

@seanshahkarami
Copy link
Member

seanshahkarami commented Mar 13, 2017

There are a few places which I'd like to revisit to limit how bad we'd be affected by a long timeout set by the user.

One example of this is the stop command. You're able to pass a parameter indicating how long the system should wait before stopping a device. If you run that with a really large time parameter and and shutdown the node controller, then currently in the worst case, assuming everything else runs flawlessly, you'd have to wait about 50 days to see it come back up.

I think it'd be reasonable to limit these parameters for something like 30 minutes or an hour at most for safety reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant