Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-view-transitions-2] Should ::view-transition-group(auto) match view-transition-name: auto? #10978

Open
noamr opened this issue Oct 1, 2024 · 3 comments
Labels
css-view-transitions-2 View Transitions; New feature requests

Comments

@noamr
Copy link
Collaborator

noamr commented Oct 1, 2024

Requesting a clarification for this resolution.
Do we want ::view-transition-{group|old|new|image-pair}(auto) to match pseudo-elements generated from the auto keywords, or do people need to use only classes to style them?

/cc @nt1m @fantasai @khushalsagar @vmpstr

@khushalsagar khushalsagar added the css-view-transitions-2 View Transitions; New feature requests label Oct 1, 2024
@khushalsagar
Copy link
Member

I'd be fine either way. Ideally authors would use the view transition class but I don't see the harm in allowing auto to match any pseudo with an auto generated name.

Relates question, what should be the name of the pseudo for Animation objects returned by getAnimations. Should it also be ::view-transition-group(auto)?

@nt1m
Copy link
Member

nt1m commented Oct 1, 2024

Same opinion as Khushal, maybe @fantasai has more opinions?

@noamr
Copy link
Collaborator Author

noamr commented Oct 4, 2024

Also, how should auto pseudo-elements appear in getAnimations({subtree: true})[...].effect.pseudoElement ? Probably also as auto? Or as *?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-view-transitions-2 View Transitions; New feature requests
Projects
None yet
Development

No branches or pull requests

3 participants