Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling section #389

Merged
merged 9 commits into from
Jun 18, 2024

Conversation

PatStLouis
Copy link
Collaborator

@PatStLouis PatStLouis commented Jun 4, 2024

Addresses #383 #340 #331 and #141

Standing questions:

RFC 9457 or RFC 7807?

What should the relationship with verification algorithms from the spec be?

Should we define specific error codes for each ProblemDetails?

Is it fair to assume that if an errors are returned the credential is not verified but if only warning are returned it is verified? (see list of error/warnings in the PR for details)

Keyword status vs code...


Preview | Diff

Signed-off-by: pstlouis <patrick.st-louis@opsecid.ca>
Signed-off-by: pstlouis <patrick.st-louis@opsecid.ca>
PatStLouis and others added 2 commits June 4, 2024 14:53
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@msporny
Copy link
Contributor

msporny commented Jun 4, 2024

The group discussed this on the 2024-06-04 telecon:

RFC 9457 or RFC 7807?

RFC 9457 should be used.

What should the relationship with verification algorithms from the spec be?

We shouldn't tie too closely to VCDM v2.0 since the API could be used to issue mDL, mDoc, and other types of digital credentials.

Should we define specific error codes for each ProblemDetails?

Not yet. We need to make sure we don't mix "HTTP Error Codes" with "ProblemDetails" codes. We need to update the ProblemDetails object to align w/ RFC 9457 (add the "status" field). We need to also figure out (later, in another PR) what to do for things like "error revoked" when validating a VC, and so on.

Is it fair to assume that if an errors are returned the credential is not verified but if only warning are returned it is verified? (see list of error/warnings in the PR for details)

This feels like a safe assumption to make.

Keyword status vs code...

"status" is for "HTTP Error Codes" (200, 400, etc.) and "code" is for integer codes returned by low-level libraries.

Signed-off-by: pstlouis <patrick.st-louis@opsecid.ca>
Signed-off-by: pstlouis <patrick.st-louis@opsecid.ca>
@PatStLouis PatStLouis marked this pull request as ready for review June 11, 2024 19:00
@PatStLouis PatStLouis requested a review from wes-smith June 11, 2024 19:00
Copy link
Contributor

@aljones15 aljones15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: pstlouis <patrick.st-louis@opsecid.ca>
PatStLouis and others added 2 commits June 18, 2024 15:20
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>
@msporny msporny merged commit 494f0a2 into w3c-ccg:main Jun 18, 2024
1 check passed
@PatStLouis PatStLouis deleted the pstlouis/add-error-handling-section branch August 6, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants