-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error handling section #389
Add error handling section #389
Conversation
Signed-off-by: pstlouis <patrick.st-louis@opsecid.ca>
Signed-off-by: pstlouis <patrick.st-louis@opsecid.ca>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
The group discussed this on the 2024-06-04 telecon:
RFC 9457 should be used.
We shouldn't tie too closely to VCDM v2.0 since the API could be used to issue mDL, mDoc, and other types of digital credentials.
Not yet. We need to make sure we don't mix "HTTP Error Codes" with "ProblemDetails" codes. We need to update the ProblemDetails object to align w/ RFC 9457 (add the "status" field). We need to also figure out (later, in another PR) what to do for things like "error revoked" when validating a VC, and so on.
This feels like a safe assumption to make.
"status" is for "HTTP Error Codes" (200, 400, etc.) and "code" is for integer codes returned by low-level libraries. |
Signed-off-by: pstlouis <patrick.st-louis@opsecid.ca>
Signed-off-by: pstlouis <patrick.st-louis@opsecid.ca>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: pstlouis <patrick.st-louis@opsecid.ca>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Manu Sporny <msporny@digitalbazaar.com>
Addresses #383 #340 #331 and #141
Standing questions:
RFC 9457 or RFC 7807?
What should the relationship with verification algorithms from the spec be?
Should we define specific error codes for each ProblemDetails?
Is it fair to assume that if an errors are returned the credential is not verified but if only warning are returned it is verified? (see list of error/warnings in the PR for details)
Keyword status vs code...
Preview | Diff