Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response body for POST /credentials/status #141

Closed
OR13 opened this issue Mar 5, 2021 · 4 comments
Closed

Response body for POST /credentials/status #141

OR13 opened this issue Mar 5, 2021 · 4 comments
Assignees
Labels
ready for PR Issue ready to be resolved via a Pull Request

Comments

@OR13
Copy link
Contributor

OR13 commented Mar 5, 2021

What is it supposed to be?

I assume the updated revocation list credential.

probably the request payload should take a number instead of as string as well:

POST https://vc.example/credentials/status

{
  "credentialId": "https://vc.example/credentials/aabe7aca-e4aa-4e1f-b08c-a86dddc5b0c3",
  "credentialStatus": [
    {
      "type": "RevocationList2020Status",
      "status": "1"
    }
  ]
}

for example:

let revoked = credentialStatus[0].status === "1" ? true : false;
@OR13
Copy link
Contributor Author

OR13 commented Feb 8, 2022

Here is a postman test confirming this behavior: w3c-ccg/traceability-interop#84

@OR13
Copy link
Contributor Author

OR13 commented Mar 21, 2022

No feedback on issue, tagging as evidence revocation is poorly understood / implemented and should be removed.

@msporny
Copy link
Contributor

msporny commented Oct 11, 2022

This was discussed on the 2022-10-11 telecon. @dlongley noted that Digital Bazaar's implementation currently provides a status code, with an empty body. If there is an error, there is an error that's returned in the standard error format. StatusList2021 could return back the updated credential, but it might be advantageous to not do that (people might want implementations that update that in a background process). We might want to hear if clients need the updated value or whether or not that's necessary. If it's not necessary, we might not want response value. The question was asked if anyone thought we should be returning anything in the body of if just a status code was enough. Positive is 200, negative is 400 which should include error (if possible).

Pull request should update the POST /credentials/status endpoint such that a positive modification provides a 2xx status code with no content in the response body and a failure returns a 4xx or 5xx with the error included in the response body.

@msporny msporny added ready for PR Issue ready to be resolved via a Pull Request and removed revocation-should-be-removed labels Oct 11, 2022
@msporny msporny assigned PatStLouis and unassigned OR13 Dec 5, 2023
@msporny
Copy link
Contributor

msporny commented Jun 18, 2024

PR #389 has been merged, which addresses this issue. Closing.

@msporny msporny closed this as completed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for PR Issue ready to be resolved via a Pull Request
Projects
None yet
Development

No branches or pull requests

3 participants