-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slider min and max values restrictions / Save values of the adjust parameters pop up window #16
Comments
First issueI've been meaning to get around to updating the The latest iteration of the GUI that I'm testing out has the following widgets (and the inputs and checkboxes for the lower and upper limits during fitting):
Typing a value into the input field updates the slider and the drop-down list on the second row, and moving the slider or selecting another SI prefix updates the input field. Making the slider represent Any comments regarding this new approach? You mentioned that you typically work with small resistances. One of the items on my list of things to add is a window where the user can change the default values of circuit elements (e.g., the default resistance could be set to 0.5 ohm). Second issueWhen you say that re-opening the |
First IssueSo for the slider I apologize but I was doing it wrong. I did not see that the values for each component could be initialized in the circuit editor. With the initialization I think the slider range is plenty good as is. Second IssueWhat I meant is that the "adjust parameters" window is not updated with the fitting results. Most of the time, we would want to be able to try various combinations of parameters, fix some, etc. to yield the best fit through trial and error. This is much easier if we can run the fit once, then tweak some parameters (starting from the fit results), and run the fit again. Do you think it is possible to fetch the fitted values and update the intitial values in the adjust parameters window for a subsequent fit? |
First issueI agree regarding the first point and I'm working on merging the Second issueThe work-in-progress update includes an |
OK for the responses of the first point, looking forward to testing the merged window. |
Merging the two windows will take a while to do since it makes the management of the state more complicated. At the moment, the implementation of the I already implemented the automatic updating, but I can easily revert that. It might be, as you stated, better to make the process of updating the initial values an explicit choice that requires an action by the user rather than doing it by default. The old You can copy the |
I've been busy working on the next version of pyimpspec and a related article, but both of those have now been released and I'm now working on finishing up version 5.0.0 of DearEIS. The ability to adjust parameters is now included in the |
Version 5.0.0 is now available. |
Hi Thank you for all your efforts! I will upgrade to 5.0.0 and give it a try as soon as I can and give you my feedback. |
Hi, I have been trying to use the app on my EIS data and I really like it so far but two things would make it much better in my opinion.
After loading the data, in the fitting tab I can easily create my equivalent circuit (love the node editor type feature!), but when it comes to adjusting the initial parameters there are two main issues:
I am not sure how hard those two suggestions would be to implement, but it is really what keeps me from using the app full time and finally ditch Zview for good!
The text was updated successfully, but these errors were encountered: