Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow multiple paths to .compile_files() #35

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

antazoey
Copy link
Contributor

What I did

Allows passing in mutliple paths to .compile_files(). This allows us to pass in site-packages for using snekmate, otherwise I can't get it to work for some reason.

How I did it

new paths kwarg to the wrapper and use that instead of -p in the _compile() method.

How to verify it

can compile a contract with snekmate now

Checklist

  • I have confirmed that my PR passes all linting checks
  • I have included test cases
  • I have updated the documentation (README.md)
  • I have added an entry to the changelog

@antazoey
Copy link
Contributor Author

I can attempt to add a test if this is agreeable.

@charles-cooper
Copy link
Member

please fix tests + lint

@antazoey
Copy link
Contributor Author

the flake8 error makes no sense, requests is used. Removing it obviously causes failures.

@antazoey
Copy link
Contributor Author

Tests failing because i pushed too much, oops.

@antazoey antazoey marked this pull request as ready for review January 27, 2025 17:45
@antazoey
Copy link
Contributor Author

please fix tests + lint

OK this one should be ready now

Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think the test failure is from an unrelated downstream update

vvm/wrapper.py Outdated Show resolved Hide resolved
Co-authored-by: Charles Cooper <cooper.charles.m@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants