Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

Use eventual assertion in contract watcher test #109

Closed
wants to merge 1 commit into from

Conversation

rmulhol
Copy link
Contributor

@rmulhol rmulhol commented Jun 20, 2019

hopefully resolves #100

@i-norden
Copy link
Collaborator

The more I think about this err the more confused I get... Everything in this test should be synchronous, so the err = t.Init() should block until processing is complete and we shouldn't need to wait for anything... I must be missing something.

@rmulhol
Copy link
Contributor Author

rmulhol commented Jun 21, 2019

Yeah, good point. I was thinking that some of the polling functionality depends on network calls that could have some inbuilt goroutines, but it's especially confusing that the error we're seeing appears to derive from missing database stuff that's put there before Init is called. Wondering if the BeforeEach/AfterEach stuff might be putting us in a race condition? Weird that it was consistently happening with basically just this test 🤔

@rmulhol
Copy link
Contributor Author

rmulhol commented Oct 2, 2019

Closing because it doesn't seem like this should fix the error. Hopefully additional logging from #145 will assist future debugging.

@rmulhol rmulhol closed this Oct 2, 2019
@rmulhol rmulhol deleted the contract-watcher-test branch October 17, 2019 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contract_watcher_header_sync_transformer_test.go fails unexpectedly
2 participants