This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
Fix flaxy tests #108
Closed
Fix flaxy tests #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- facilitates making (async) assertions on individual fields from other packages
- Hoping to reduce flakiness by allowing multiple checks with timeout
- Hoping to fix flakiness
rmulhol
requested review from
m0ar,
yaoandrew,
elizabethengelman,
Gslaughl and
i-norden
|
welp I guess this isn't going to fix the Geth blockchain test if the issue there is that we're seeing an error on |
|
Going to close this because the commits dealing with the Geth blockchain test aren't likely to fix flakiness surrounding the network call failing. On board with seeing if we can swap in a node that provides more consistent responses, and will open a separate PR to address the contract watcher test. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoping this resolves #100 and the latest flakiness we're seeing out of the Geth blockchain test