Skip suppressed records when indexing. #53
Conversation
| boolean skipDocument = false; | ||
| if (skipField != null) { | ||
| String[] skip = doc.getValues(skipField); | ||
| skipDocument = Arrays.asList(skip).contains("T"); |
There was a problem hiding this comment.
It is insane to me that the API returns "T" for the boolean true, but so be it.
|
I developed this against our production VuFind 9.1, which uses an older version of this vufind-browse-handler, library, so have not tested it as is here. Will hopefully do so late summer (once we upgrade locally) unless someone beats me to it. So leaving as draft for a while. |
|
Thanks, @maccabeelevine! Do you think it might be worth making this a little more flexible, e.g. to allow filtering on more than just Boolean types? At Villanova, we use a string field to index the contents of FOLIO's OAI-generated 999$t, so this logic wouldn't work for us in its current form. It would certainly be possible for us to change our indexing processes to make it work, but I imagine there might be other use cases where filtering on one or more string values could be helpful (e.g. using locations to generate separate browse indexes for different members of a consortium). I'm certainly open to accepting this as-is and generalizing it later, but I wanted to suggest these possibilities in case generalizing it now would be worth the effort. (It would certainly be easier for me to help test if I didn't need to redesign my own local index to do so). |
The Solr index may contain records that should be suppressed for discovery, i.e. this in searches.ini
Those records are still present in the browse indexes because they don't use these hidden filter settings. This PR allows a the same boolean Solr field to be used to skip records in the browse index as well.