Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug in shippingMethodId is ID! instead of [ID!]! #245

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

ralphsomeday
Copy link
Contributor

Fixing bug in shippingMethodId is ID! instead of [ID!]! in setOrderShippingMethodMutation.ts when integrating with vendure v2.1.6

Description

Following error was happening with vendure 2.1.6 using vuestorefront with vendure integration: [VSF][error]: [GraphQL error]: Message: Variable "$shippingMethodId" of type "ID!" used in position expecting type "[ID!]!"., Location: [column: 33, line: 119], [column: 44, line: 120], Path: undefined

Noticed the issue was due to the fact that the variable shippingMethodId in node_module folder @vue-storefront > vendure-api > server > index.js had the wrong type set for shippingMethodId which was crashing vue-storefront app when trying to order and setting the shipping method

Related Issue

(#244)

Motivation and Context

You basically cannot place any order to the vendure integration does not work

How Has This Been Tested?

Change the code in the node_module index.js file that was generated code and it start working (meaning i could place an order)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…ippingMethodMutation.ts when integrating with vendure v2.1

Following error was happening with vendure 2.1.6 using vuestorefront with vendure integration: [VSF][error]:  [GraphQL error]: Message: Variable "$shippingMethodId" of type "ID!" used in position expecting type "[ID!]!"., Location: [column: 33, line: 119], [column: 44, line: 120], Path: undefined

Noticed the issue was due to the fact that the variable shippingMethodId in node_module folder @vue-storefront > vendure-api > server > index.js had the wrong type set for shippingMethodId which was crashing vue-storefront app when trying to order and setting the shipping method
@ralphsomeday
Copy link
Contributor Author

@bloodf

@bloodf bloodf merged commit 2cd1730 into vuestorefront-community:develop Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants