feat: Document support image preview #1504
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could be nice feature to add, but I would like to adjust the stylings a bit. I'll look into it when I get time! |
|
Also, there was some discussion on this. Refer #854, it is straightforward to add if someone wants (the example is outdated though 😅, #854 (comment) will fix route change issues). |
|
brc-dd
force-pushed
the
main
branch
2 times, most recently
from
7ad4a4e
to
f0d3082
Compare
|
Is there still a chance for this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About PR
We often insert pictures in documents，But currently does not support preview images, so i add this feature on this pr.
we can preview like this:
Operation Video
demo
As long as img is used in the document, clicking on this image can trigger the preview effect， like this: