Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VitePress does not honor vite.build.ssr = false #3162

Closed
4 tasks done
Swivelgames opened this issue Oct 31, 2023 · 1 comment
Closed
4 tasks done

VitePress does not honor vite.build.ssr = false #3162

Swivelgames opened this issue Oct 31, 2023 · 1 comment

Comments

@Swivelgames
Copy link

Describe the bug

Trying to build with vite.build.ssr = false, but it appears that VitePress continues to bundle everything as if preparing it to be served with a backend.

Reproduction

Build VitePress with vite.build.ssr = false

Expected behavior

Paths will become absolute and referenced modules will be bundled with the dist, unless excluded with rollupOptions.external.

System Info

System:
    OS: macOS 13.5.1
    CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
    Memory: 487.25 MB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 18.18.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 9.8.1 - /usr/local/bin/npm
    pnpm: 8.7.6 - /usr/local/bin/pnpm
  Browsers:
    Safari: 16.6
    Firefox: 118.0.2
    Chrome: 118.0.5993.117
  npmPackages:
    vitepress: 1.0.0-rc.14 => 1.0.0-rc.14

Additional context

VitePress should respect disabling SSR to allow for hosting via CDN.

Validations

@Swivelgames Swivelgames added the bug: pending triage Maybe a bug, waiting for confirmation label Oct 31, 2023
@brc-dd
Copy link
Member

brc-dd commented Nov 1, 2023

I think you're confused between what SSR in this context means. VitePress performs SSR to generate static HTML/JS/CSS. You can host that wherever you want. You don't need a backend to serve that. Regarding paths, you probably need #2467

@brc-dd brc-dd removed the bug: pending triage Maybe a bug, waiting for confirmation label Nov 1, 2023
@brc-dd brc-dd closed this as not planned Won't fix, can't repro, duplicate, stale Nov 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants