Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling no prefix tag #54

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Enabling no prefix tag #54

wants to merge 3 commits into from

Conversation

philcvlcnt
Copy link

What is the purpose of this pull request?

Enable tag release with no prefix

What problem is this solving?

Using current releasy version we get urls with the prefix v, like this
https://io.vtex.com.br/i18n/v0.1.183/catalog/en-US.json
but we want them with no prefix, like this
https://io.vtex.com.br/i18n/0.1.184/catalog/en-US.json?

How should this be manually tested?

Screenshots or example usage

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@philcvlcnt
Copy link
Author

Which lint should I use to solve the issue above?

@lucasecdb
Copy link
Contributor

@philcvlcnt you can run yarn lint --fix in the repo root

bin/releasy.js Show resolved Hide resolved
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

## [1.13.0] - 2021-02-10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be added by the releasy when it bumps the version

Suggested change
## [1.13.0] - 2021-02-10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants