Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pickup selected is changing when page reloads #7

Merged
merged 2 commits into from
Oct 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed

- Selected pickup did not change.

## [0.3.0] - 2024-10-04

### Added
Expand Down
20 changes: 15 additions & 5 deletions react/hooks/useShippingOptions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { useRuntime, useSSR } from 'vtex.render-runtime'
import { useIntl } from 'react-intl'
import { usePixel } from 'vtex.pixel-manager'

import { getCountryCode, getOrderFormId, getZipCode } from '../utils/cookie'
import { getCountryCode, getOrderFormId, getFacetsData } from '../utils/cookie'
import messages from '../messages'
import {
getAddress,
Expand Down Expand Up @@ -37,15 +37,25 @@ const useShippingOptions = () => {

setPickups(responsePickups.items)

if (responsePickups.items.length === 0) {
if (responsePickups?.items?.length === 0) {
setIsLoading(false)

return
}

setSelectecPickup(responsePickups.items[0])
let [pickup] = responsePickups.items

await updateSession(zipCode, coordinates, responsePickups.items[0])
const pickupPointId = getFacetsData('pickupPoint')

if (pickupPointId) {
pickup = responsePickups.items.find(
(p: any) => p.pickupPoint.id === pickupPointId
)
}

setSelectecPickup(pickup)

await updateSession(zipCode, coordinates, pickup)

setIsLoading(false)
},
Expand All @@ -57,7 +67,7 @@ const useShippingOptions = () => {
return
}

const segmentZipCode = getZipCode()
const segmentZipCode = getFacetsData('zip-code')
const segmentCountryCode = getCountryCode()

setSelectedZipCode(segmentZipCode)
Expand Down
16 changes: 8 additions & 8 deletions react/utils/cookie.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export function getCookie(name: string) {
return undefined
}

export function getZipCode() {
export function getFacetsData(facetsDataTarget: string) {
const segment = (window as any)?.__RUNTIME__.segmentToken

if (!segment) {
Expand All @@ -22,21 +22,21 @@ export function getZipCode() {
return
}

const zipCodeFacet = facets
const facetsTarget = facets
.split(';')
.find((facet: string) => facet.indexOf('zip-code') > -1)
.find((facet: string) => facet.indexOf(facetsDataTarget) > -1)

if (!zipCodeFacet) {
if (!facetsTarget) {
return
}

const [, zipCode] = zipCodeFacet.split('=')
const [, data] = facetsTarget.split('=')

if (zipCode && zipCode[zipCode.length - 1] === ';') {
return zipCode.substring(0, zipCode.length - 1)
if (data && data[data.length - 1] === ';') {
return data.substring(0, data.length - 1)
}

return zipCode
return data
}

export function getCountryCode() {
Expand Down
Loading