Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pickup selected is changing when page reloads #7

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

ArthurFerrao
Copy link
Contributor

@ArthurFerrao ArthurFerrao commented Oct 3, 2024

What problem is this solving?

The store does not change when we try to choose one from the pickup selector.
SAX-354

How to test it?

Change the store in the pickup selector on the header.

Workspace

Screenshots or example usage:

Gravacao.de.Tela.2024-10-03.as.19.28.33.mov

Describe alternatives you've considered, if any.

Related to / Depends on

How does this PR make you feel? 🔗

Copy link

vtex-io-ci-cd bot commented Oct 3, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@ArthurFerrao ArthurFerrao merged commit 6e4cdc0 into main Oct 4, 2024
5 checks passed
Copy link

vtex-io-ci-cd bot commented Oct 4, 2024

Your PR has been merged! App is being published. 🚀
Version 0.3.0 → 0.4.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.shipping-option-components@0.4.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

@ArthurFerrao ArthurFerrao deleted the fix/pickup-selected branch October 4, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants