Prefix db (table not found)

[mgralikowski]

There is a problem with database prefixing.

SQLSTATE[42S02]: Base table or view not found: 1146 Table 'default.prefix_ltm_translations' doesn't exist (SQL: select locale from prefix_ltm_translations group by locale)

Library ignores that default connection has set "prefix".

Furthermore if i try to manually change column to "ltm_translations" (to non-prefixed version) still is error, this time:

SQLSTATE[42S02]: Base table or view not found: 1146 Table 'default.ltm_translations' doesn't exist

I guess there is mix of raw queries and eloquent queries. The solution is use DB::getTablePrefix() or similar in this raw queries.

[vsch]

@mgralikowski, I will check the repository code to make sure it uses the variable for the translation table instead of assuming that it is ltm_translations. The SQL queries have to add the prefix manually.

[mgralikowski]

I found Your method adjustTranslationTable(). For me is not proper way (better is variable with prefixed table name or with only prefix) but do a job ;) My PR remove space which cause that replacing doesn't work.

[vsch]

@mgralikowski, in repository the proper function is getTranslationsTableName()

I missed a whole bunch of queries which used ltm_translations instead of getting the proper table name.

I am fixing it now and will release a fixed version.

[vsch]

@mgralikowski, fixed version released.

[mgralikowski]

Should i use master version to get this fix? For now i use 5.5.

[vsch]

@mgralikowski, I will need to apply the fix to 2.5 branch.

[mgralikowski]

Is master branch safe to use in production and L 5.5?

[vsch]

@mgralikowski, I have not tested it with 5.5 and there were a lot of changes in that branch from laravel 5.5 branch.

Unless you upgrade to Laravel 5.6 I would not recommend it.

[mgralikowski]

Ah, ok.

So please, just accept pull request with this small fix #132 in 5.5 branch. It's enough for me to make production deployment.

[vsch]

@mgralikowski, made a release into Laravel-5.5 branch with merge #132