Skip to content

Commit

Permalink
I find it worrying that the user has write access everywhere, tryign …
Browse files Browse the repository at this point in the history
…out this.
  • Loading branch information
mihxil committed Feb 4, 2025
1 parent 8c10321 commit 9d6e994
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,9 @@ RUN echo Catalina base: ${CATALINA_BASE} && \
(echo -e "vpro/tomcat git version=${CI_COMMIT_SHA}\t${CI_COMMIT_REF_NAME}\t${CI_COMMIT_TIMESTAMP}\t${CI_COMMIT_TITLE}") > /DOCKER.BUILD && \
(echo -n "vpro/tomcat build time=" ; date -Iseconds) >> /DOCKER.BUILD


RUN useradd tomcat

# The onbuild commands to install the application when this image is overlaid

ONBUILD ARG PROJECT_VERSION
Expand Down Expand Up @@ -205,3 +208,6 @@ ONBUILD RUN apt-get update && apt-get -y upgrade && \
(echo "${NAME} version=${PROJECT_VERSION}") >> /DOCKER.BUILD && \
(echo -e "${NAME} git version=${CI_COMMIT_SHA}\t${CI_COMMIT_REF_NAME}\t${CI_COMMIT_TIMESTAMP}\t${CI_COMMIT_TITLE}") >> /DOCKER.BUILD && \
(echo -n "${NAME} build time=" ; date -Iseconds) >> /DOCKER.BUILD


USER tomcat
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ run: ## Run the build image
docker run -i $(IMAGE)

exec: ## Look around in the build image
docker run -it --entrypoint /bin/bash $(IMAGE)
docker run -it --entrypoint /bin/bash -v /data:/data $(IMAGE)

exectest:
docker run -it --entrypoint /bin/bash vpro/test:latest
Expand Down

0 comments on commit 9d6e994

Please sign in to comment.