Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixbug: save obj file streamwriter has no close #234

Closed
wants to merge 2 commits into from

Conversation

jackletter
Copy link

No description provided.

@vpenades
Copy link
Owner

vpenades commented May 9, 2024

Thanks for your bugfix, but in its current state I cannot merge it, because it does not follow good programming practices.

streams need to be closed/disposed by the same function that opened them to ensure the stream is properly handled.

So the right way to do it is to expand the lambda funciont and dispose the stream after having called the _GetGeometryContent method.

@jackletter
Copy link
Author

@vpenades yes, you are wright, but the bug need fix, otherwise the *.obj file is incomplete

@vpenades
Copy link
Owner

vpenades commented May 9, 2024

I'll give a look at the wavefront and figure out another way of fixing this

@vpenades
Copy link
Owner

I've been able to fix it on my end, so this pull request is no longer neccesary.

Thanks for hilighting the issue.

@vpenades vpenades closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants