Load puppet versions from shared file & Add missing factsets #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow scripts for different operating systems to be separated and still use the same versions This also helps keep track of what facter versions are being used with each version of Puppet Agent. Tested on RHEL 9, openSUSE 15.4, Ubuntu 20.04, Windows 10, Windows Server 2019 Inspired by voxpupuli#330
yakatz
force-pushed
the
windows_puppet_versions
branch
from
578b94a to
cb32548
Compare
yakatz
force-pushed
the
windows_puppet_versions
branch
from
719ed3a to
3042490
Compare
bastelfreak
approved these changes
May 16, 2024
ekohl
approved these changes
May 16, 2024
For Windows, it doesn't matter because the download links are probably the same. For OSes that need different repos, the change to loading the file is minimal: puppet8_agent_versions=$(grep --only-matching --perl-regexp '^8\.\d+\.\d+' $puppetAgentVersionList)
puppet9_agent_versions=$(grep --only-matching --perl-regexp '^9\.\d+\.\d+' $puppetAgentVersionList) |
bastelfreak
changed the title
|
I adjusted the PR title and removed the label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow scripts for different operating systems to be separated and still use the same versions
This also helps keep track of what facter versions are being used with each version of Puppet Agent.
Tested on RHEL 9, openSUSE 15.4, Ubuntu 20.04, Windows 10/11, Windows Server 2019/2022
Inspired by #330