-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop EoL cisco support #1872
Drop EoL cisco support #1872
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In spec/beaker/dsl/test_tagging_spec.rb
I still see some cisco stuff. Perhaps change those examples to Windows?
for it 'deals with the same tag being used on multiple platforms correctly' do
@confines_array = [
{
:platform => /^el-/,
:tag_reason_hash => {
'tag1' => 'reason el 1',
'tag2' => 'reason2',
},
}, {
:platform => /^cisco-/,
:tag_reason_hash => {
'tag1' => 'reason cisco 1',
'tag3' => 'reason3',
},
},
]
internal_hash = confiner.instance_variable_get(:@tag_confine_details_hash)
expect(internal_hash.keys).to include('tag1')
expect(internal_hash.keys).to include('tag2')
expect(internal_hash.keys).to include('tag3')
expect(internal_hash.keys.length).to be === 3
shared_tag_array = internal_hash['tag1']
expect(shared_tag_array.length).to be === 2
platform_el_found = false
platform_cisco_found = false
shared_tag_array.each do |confine_details|
case confine_details[:log_message]
when /\ el\ 1/
platform_el_found = true
platform_to_match = /^el-/
reason_to_match = /reason\ el\ 1/
when /\ cisco\ 1/
platform_cisco_found = true
platform_to_match = /^cisco-/
reason_to_match = /reason\ cisco\ 1/
else
log_msg = "unexpected log message for confine_details: "
log_msg << confine_details[:log_message]
fail(log_msg)
end
expect(confine_details[:platform_regex]).to eql(platform_to_match)
expect(confine_details[:log_message]).to match(reason_to_match)
end
expect(platform_el_found).to be === true
expect(platform_cisco_found).to be === true
end
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also update it later.
Puppet doesnt support cisco anymore since some time.
Puppet doesnt support cisco anymore since some time.