drop sys-v leftovers; assume systemctl is available for unknown platforms #1868
Conversation
bastelfreak
force-pushed
the
systemd
branch
4 times, most recently
from
7ba1253 to
7713a1e
Compare
bastelfreak
changed the title
bastelfreak
force-pushed
the
systemd
branch
4 times, most recently
from
0db7b9a to
cb575da
Compare
bastelfreak
force-pushed
the
systemd
branch
4 times, most recently
from
d325cce to
97a4a43
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1868 +/- ##
==========================================
- Coverage 74.62% 74.29% -0.33%
==========================================
Files 81 79 -2
Lines 4492 4396 -96
==========================================
- Hits 3352 3266 -86
+ Misses 1140 1130 -10 ☔ View full report in Codecov by Sentry. |
|
will wait with merging until EOS/cisco are dropped |
|
We still support EL6 in puppet 7, though have plans to drop it soonish. RHEL 7 is offering extended support until June 30, 2028, so we don't have plans on dropping it. We also support SLES 11. |
bastelfreak
force-pushed
the
systemd
branch
5 times, most recently
from
9a8a474 to
c35497b
Compare
bastelfreak
force-pushed
the
systemd
branch
2 times, most recently
from
f008145 to
be79965
Compare
This also drops support for linux systems without systemd, for example EL6. But we don't support those anymore since a long time.
| when /opensuse|sles/ | ||
| exec(Beaker::Command.new("/usr/sbin/rcsshd restart")) |
There was a problem hiding this comment.
I think @joshcooper wanted to say that SLES 11 still hit this code. IMHO we should treat it like EL 6: special case it and less SLES 12+ fall through to systemd.
There was a problem hiding this comment.
Yes, I'm good with defaulting to systemd and special casing older platforms. Can you restore the ability to start services on SLES 11 using /usr/sbin/rcsshd restart?
There was a problem hiding this comment.
but the question is the same as for EL6: How long will Puppet support those platforms? does it make sense for us to carry on with non-systemd support?
There was a problem hiding this comment.
RHEL 6 will have Extended LIfecycle Support until June 30, 2024 based on https://access.redhat.com/articles/4665701#6-how-can-i-continue-to-receive-software-maintenance-bug-and-security-fixes-and-full-technical-support-for-red-hat-enterprise-linux-6-6
But they could extend it, similar to how Oracle extended Solaris 10 until Jan 2027 https://blogs.oracle.com/solaris/post/new-end-date-of-extended-support-for-oracle-solaris-10-and-113
Also SLES 11 is something we will be supporting for some time.
| end | ||
| end | ||
|
|
||
| PlatformHelpers::SYSTEMVPLATFORMS.each do |platform| |
There was a problem hiding this comment.
Would have been nice to keep this for EL6.
There was a problem hiding this comment.
@joshcooper do you still rely on it? Vox Pupuli doesn't support EL6 anymore and I suspect you won't update to beaker 6 soonish and drop EL6 from your pipelines anyways?
There was a problem hiding this comment.
We special cased it in the code. Either we should have dropped it or implemented tests. We kept it in at @joshcooper's request so I'd like to test it
This also drops support for linux systems without systemd, for example EL6. But we don't support those anymore since a long time.