From d293cbcc8b869db6be277df458b4645762ad5a7b Mon Sep 17 00:00:00 2001 From: Tim Meusel Date: Fri, 10 May 2024 17:06:16 +0200 Subject: [PATCH] drop validate_setup method This wasn't implemented for unix hosts anyways and we're going to drop the few network operating systems that used it. --- .rubocop_todo.yml | 6 +++--- lib/beaker/host/unix.rb | 9 --------- lib/beaker/network_manager.rb | 1 - 3 files changed, 3 insertions(+), 13 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index cc2047f72..08ebdf846 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2024-05-10 14:44:46 UTC using RuboCop version 1.62.1. +# on 2024-05-10 15:53:37 UTC using RuboCop version 1.62.1. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -155,7 +155,7 @@ RSpec/Eq: Exclude: - 'spec/beaker/logger_spec.rb' -# Offense count: 232 +# Offense count: 231 # Configuration parameters: CountAsOne. RSpec/ExampleLength: Max: 44 @@ -219,7 +219,7 @@ RSpec/MultipleMemoizedHelpers: RSpec/NamedSubject: Enabled: false -# Offense count: 42 +# Offense count: 41 # Configuration parameters: AllowedPatterns. # AllowedPatterns: ^expect_, ^assert_ RSpec/NoExpectationExample: diff --git a/lib/beaker/host/unix.rb b/lib/beaker/host/unix.rb index ca88425f5..ca8cef3bf 100644 --- a/lib/beaker/host/unix.rb +++ b/lib/beaker/host/unix.rb @@ -57,15 +57,6 @@ def skip_set_env? end end - # Validates that the host was setup correctly - # - # @return nil - # @raise [ArgumentError] If the host is setup incorrectly, - # this will be raised with the appropriate message - def validate_setup - nil - end - def initialize name, host_hash, options super diff --git a/lib/beaker/network_manager.rb b/lib/beaker/network_manager.rb index da6ae51f1..10dd96a17 100644 --- a/lib/beaker/network_manager.rb +++ b/lib/beaker/network_manager.rb @@ -61,7 +61,6 @@ def provision @machines[hypervisor] = [] unless @machines[hypervisor] hostless_options[:timesync] = host_hash[:timesync] if host_hash[:timesync] != nil host_itself = Beaker::Host.create(name, host_hash, hostless_options) - host_itself.validate_setup @machines[hypervisor] << host_itself end