Issues/improve jsonschema speed #1537
Merged
+28
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This precompiles the schema file for jsonschema, meaning that (for some reason) it's already faster than the old combined method, but also if many json files are verified against the same schema there'll be a several second win each additional time (due to not having to recompile the schema).
I tried using fastjsonschema but the error messages are less descriptive and it fails validation for most of our existing handcoded and generated files, because the timestamps they generate don't include the timezone offset at the end (+XX:XX) finding all datetimes within a json file would be a pig (and slow) so better to change the validator somehow (still investigating) and/or figure out why jsonschema allows the old times and fastjsonschema does not...
Anyway, lemme know what you think and if the changes speed-up your testing workflow much?