Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/domain: add support to use name #207

Closed
4 tasks done
insidepacket opened this issue Jul 30, 2024 · 3 comments · Fixed by #228
Closed
4 tasks done

d/domain: add support to use name #207

insidepacket opened this issue Jul 30, 2024 · 3 comments · Fixed by #228
Assignees
Labels
datasource Provider Datasource enhancement Enhancement
Milestone

Comments

@insidepacket
Copy link
Contributor

insidepacket commented Jul 30, 2024

Code of Conduct

  • I have read and agree to the project's Code of Conduct.
  • Vote on this issue by adding a 👍 reaction to the original issue initial description to help the maintainers prioritize.
  • Do not leave "+1" or other comments that do not add relevant information or questions.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Description

When using domain data resources, support for using the name of the workload domain instead of the domain ID is preferred when retrieving a domain data resource.

Use Case(s)

Using the domain ID is time-consuming and not aligned with common practice. We should support using the name of the workload domain to retrieve a domain data resource.

Potential Configuration

data "vcf_domain" "example" {
  name = var.vcf_domain_name
}

References

No response

@insidepacket insidepacket added enhancement Enhancement needs-review Needs Review labels Jul 30, 2024
@github-actions github-actions bot added the pending-review Pending Review label Jul 30, 2024
@tenthirtyam tenthirtyam added datasource Provider Datasource and removed needs-review Needs Review pending-review Pending Review labels Jul 30, 2024
@tenthirtyam tenthirtyam added this to the Backlog milestone Jul 30, 2024
@tenthirtyam tenthirtyam changed the title Using the name of the workload domain instead of the domain ID retrieves a domain data resource. Add support to use domain_name in d/vcf_domainn Jul 30, 2024
@tenthirtyam tenthirtyam changed the title Add support to use domain_name in d/vcf_domainn Add support to use domain_name in `d/vcf_domainn Jul 30, 2024
@tenthirtyam tenthirtyam changed the title Add support to use domain_name in `d/vcf_domainn Add support to use domain_name in d/vcf_domain Jul 30, 2024
@tenthirtyam tenthirtyam modified the milestones: Backlog, v0.11.0 Jul 30, 2024
@tenthirtyam tenthirtyam changed the title Add support to use domain_name in d/vcf_domain d/domain: add support to use domain_name` Jul 31, 2024
@tenthirtyam tenthirtyam changed the title d/domain: add support to use domain_name` d/domain: add support to use domain_name Jul 31, 2024
@burnsjared0415
Copy link
Contributor

i can pick up if ok

@tenthirtyam
Copy link
Contributor

Assigned to Jared Burns, VMware by Broadcom.

@tenthirtyam tenthirtyam changed the title d/domain: add support to use domain_name d/domain: add support to use name Aug 21, 2024
Copy link

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
datasource Provider Datasource enhancement Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants