fix edge cluster deployment

vmware · Oct 1, 2024 · c4f8f8a · c4f8f8a
1 parent 5c0dcd7
commit c4f8f8a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/internal/api_client/sddc_manager_client.go b/internal/api_client/sddc_manager_client.go
@@ -241,6 +241,8 @@ func GetError(body []byte) *vcf.Error {
 	return &dest
 }
 
+// LogError traverses a vcf.Error structure and logs its error message as well as
+// the messages of any nested errors
 func LogError(err *vcf.Error) {
 	if err != nil {
 		if err.Message != nil {

diff --git a/internal/nsx_edge_cluster/edge_cluster_operations.go b/internal/nsx_edge_cluster/edge_cluster_operations.go
@@ -165,11 +165,11 @@ func getNodeSpec(node map[string]interface{}, client *vcf.ClientWithResponses) (
 	interRackCluster := node["inter_rack_cluster"].(bool)
 
 	var clusterId string
-	if computeClusterId, contains := node["compute_cluster_id"]; contains {
+	if computeClusterId := node["compute_cluster_id"]; computeClusterId != "" {
 		clusterId = computeClusterId.(string)
 	}
 
-	if computeClusterName, contains := node["compute_cluster_name"]; contains {
+	if computeClusterName := node["compute_cluster_name"]; computeClusterName != "" {
 		if clusterId != "" {
 			return nil, errors.New("you cannot set compute_cluster_id and compute_cluster_name at the same time")
 		}