Fix build failures about json-c's debug.h #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
open-vm-tools currently fails to build on certain system setup due to conflicting header filename (debug.h). The errors look like:
```
copyPasteUIX11.h: In member function 'void CopyPasteUIX11::SetBlockControl(DnDBlockControl*)':
copyPasteUIX11.h:90:9: error: 'Debug' was not declared in this scope; did you mean 'g_debug'?
90 | { Debug("Setting mBlockCtrl to %p\n", blockCtrl);
| ^~~~~
| g_debug
```
This is because when util-linux's configured with cryptsetup support, a dependency chain brings in json-c's include path into GTK_CPPFLAGS and there's `/usr/include/json-c/debug.h` with the same filename.
```
gdk-pixbuf-xlib-2.0 -> gdk-pixbuf-2.0 -> gio-2.0 -> mount -> libcryptsetup -> json-c
```
Preferring our include path over GTK_CPPFLAGS fixes building here.
|
@felixonmars, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
|
@felixonmars, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed. |
|
@felixonmars, VMware has approved your signed contributor license agreement. |
MingcongBai
added a commit
to AOSC-Dev/aosc-os-abbs
that referenced
this pull request
Sep 10, 2023
Add a patch from Felix Yan to fix build against a build environment with json-c installed as a dependency. Upstream pending. Ref: vmware/open-vm-tools#680
MingcongBai
added a commit
to AOSC-Dev/aosc-os-abbs
that referenced
this pull request
Sep 10, 2023
Add a patch from Felix Yan to fix build against a build environment with json-c installed as a dependency. Upstream pending. Ref: vmware/open-vm-tools#680
MingcongBai
added a commit
to AOSC-Dev/aosc-os-abbs
that referenced
this pull request
Sep 13, 2023
Add a patch from Felix Yan to fix build against a build environment with json-c installed as a dependency. Upstream pending. Ref: vmware/open-vm-tools#680
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open-vm-tools currently fails to build on certain system setup due to conflicting header filename (debug.h). The errors look like:
This is because when util-linux's configured with cryptsetup support, a dependency chain brings in json-c's include path into GTK_CPPFLAGS and there's
/usr/include/json-c/debug.hwith the same filename.Preferring our include path over GTK_CPPFLAGS fixes building here.