Skip to content

Commit

Permalink
jooq-ddlog: cache new Object[0] as a default binding
Browse files Browse the repository at this point in the history
Signed-off-by: Lalith Suresh <lsuresh@vmware.com>
  • Loading branch information
lalithsuresh authored and Mihai Budiu committed Nov 19, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent 19e6c54 commit bf02fa7
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion sql/src/main/java/com/vmware/ddlog/DDlogJooqProvider.java
Original file line number Diff line number Diff line change
@@ -86,6 +86,7 @@
public final class DDlogJooqProvider implements MockDataProvider {
private static final String DDLOG_SOME = "ddlog_std::Some";
private static final String DDLOG_NONE = "ddlog_std::None";
private static final Object[] DEFAULT_BINDING = new Object[0];
private final DDlogAPI dDlogAPI;
private final DSLContext dslContext;
private final Field<Integer> updateCountField;
@@ -132,7 +133,7 @@ public MockResult[] execute(final MockExecuteContext ctx) throws SQLException {
dDlogAPI.transactionStart();
final Object[][] bindings = ctx.batchBindings();
for (int i = 0; i < batchSql.length; i++) {
final Object[] binding = bindings != null && bindings.length > i ? bindings[i] : new Object[0];
final Object[] binding = bindings != null && bindings.length > i ? bindings[i] : DEFAULT_BINDING;
final QueryContext context = new QueryContext(batchSql[i], binding);
mock[i] = executeOne(context);
}

0 comments on commit bf02fa7

Please sign in to comment.