Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] Explicit interface for vLLM models and support OOT embedding models #9108

Merged
merged 8 commits into from
Oct 7, 2024

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Oct 6, 2024

This PR adds interface_base.py which specifies the required methods for vLLM models, something that wasn't clear before. Hope that this can clear up some confusion during model development and refactoring efforts.

I have updated model registry tests to ensure that our existing models satisfy those interfaces.

Based on this change, we now automatically detect embedding models without relying on the internal _EMBEDDING_MODELS global, making them available for OOT - I've added tests for this as well.

Copy link

github-actions bot commented Oct 6, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 changed the title [Model] Explicit interface for vLLM models and OOT support for embedding models [Model] Explicit interface for vLLM models and support OOT embedding models Oct 6, 2024
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see some nit comments

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 7, 2024
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) October 7, 2024 04:57
@DarkLight1337 DarkLight1337 merged commit 8c6de96 into main Oct 7, 2024
57 checks passed
@DarkLight1337 DarkLight1337 deleted the embedding-oot branch October 7, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants