Add FP8 Support #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfineran
approved these changes
Jun 24, 2024
| @@ -0,0 +1,19 @@ | |||
| quant_stage: | |||
| quant_modifiers: | |||
| GPTQModifier: | |||
There was a problem hiding this comment.
nice that gptq works out of the box
but note that we shouldnt need this for fp8
so in our examples its should just be quantization modifier
perhaps we should have a test that matches the expected user flow for fp8 as well?
There was a problem hiding this comment.
Can do as follow up
There was a problem hiding this comment.
Gotcha, I just updated the PR with this change (both in the example and the integration test). However the nice scheme/target UX is only for GPTQModifier so it made the example a bit messier. I'll move the scheme parsing to QM in a follow up PR
markmc
pushed a commit
to markmc/llm-compressor
that referenced
this pull request
Nov 13, 2024
* Apply quantization config implementation * add TODO * integrate full lifecycle support, QuantizationStatus updates, add tinyllama test * fix comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating this PR from sparseml: neuralmagic/sparseml#2306