Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VLM] Qwen 2.5 VL #1113

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[VLM] Qwen 2.5 VL #1113

wants to merge 4 commits into from

Conversation

kylesayrs
Copy link
Collaborator

Purpose

  • Support quantizing Qwen 2.5 VL model

Changes

  • Add example examples/multimodal_vision/qwen_2_5_vl_example.py
  • Implement TraceableQwen2_5_VLForConditionalGeneration
  • Small style changes to TraceableQwen2_VLForConditionalGeneration

Testing

  • Ran added example to completion

Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@kylesayrs kylesayrs self-assigned this Jan 29, 2025
@kylesayrs kylesayrs added the ready When a PR is ready for review label Jan 29, 2025
Copy link
Collaborator

@brian-dellabetta brian-dellabetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must admit I don't understand a good amount of the qwen2.5-specific tracing code, and shared this with @kylesayrs , but as this is code that will only run specific to the Qwen 2/2.5 VL models, I am not being too meticulous in the review.

Thanks Kyle! 🚀

from llmcompressor.transformers.tracing import (
TraceableQwen2_5_VLForConditionalGeneration,
)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a quick ELI5 would be nice to have at the top

Suggested change
# The following example shows how the Qwen2.5 Vision-Language model can be W4A16 quantized

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the readme in this folder provides enough context for a user to know how to use this example/what it's doing

@kylesayrs kylesayrs marked this pull request as draft February 6, 2025 18:26
@kylesayrs
Copy link
Collaborator Author

Need to wait until 2.5 lands in transformers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready When a PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants