-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Idefics3/SmolVLM quant support via traceable class #1095
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @leon-seidel! This looks great to me, I look forward to getting this landed!
Co-authored-by: Kyle Sayers <kylesayrs@gmail.com>
Hi @leon-seidel I've run your example end to end and it looks good! All that's left is to fix the quality tests and this is good to land!
|
Base
W4A16
|
Signed-off-by: Leon Seidel <leon.seidel@fau.de>
Quality should be fixed now, thanks for your help! Also great tutorial on making the models traceable in the first place. I tried it on my own finetuned Idefics3 model and can't see any deterioration in the outputs! |
SUMMARY: Adding a traceable Idefics3 class following the new [guide](https://github.com/vllm-project/llm-compressor/blob/main/src/llmcompressor/transformers/tracing/GUIDE.md) to allow W4A16 quants of Idefics3 and SmolVLM (which share the same architecture). Idefics3 seems to require a max_sequence_length of 4096 and I copied the example from the Phi 3 Vision example as the dataset loading approach from the Llava example led to OOM on 64 GB RAM. TEST PLAN: Tested on A100 with Idefics3 @512 samples and on a 4060 Ti with SmolVLM @128 samples. --------- Co-authored-by: Kyle Sayers <kylesayrs@gmail.com> Signed-off-by: Rahul Tuli <rahul@neuralmagic.com>
SUMMARY:
Adding a traceable Idefics3 class following the new guide to allow W4A16 quants of Idefics3 and SmolVLM (which share the same architecture). Idefics3 seems to require a max_sequence_length of 4096 and I copied the example from the Phi 3 Vision example as the dataset loading approach from the Llava example led to OOM on 64 GB RAM.
TEST PLAN:
Tested on A100 with Idefics3 @512 samples and on a 4060 Ti with SmolVLM @128 samples.