[Test Patch] Remove redundant code for "Fix/update test_run_compressed" #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpressor into run_compressed-tests
dsikka
approved these changes
Jan 14, 2025
kylesayrs
approved these changes
Jan 15, 2025
kylesayrs
reviewed
Jan 15, 2025
| @classmethod | ||
| def tearDownClass(self): | ||
| shutil.rmtree(self.test_dir) | ||
| del self.dense_model |
There was a problem hiding this comment.
FYI there's no need to delete references manually. The references are dropped when the reference to the class is dropped, which should be when pytest finishes the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Removed breakpoints and addressed comments for #970
TEST PLAN:
Ran pytest for the two test files
#970
ORIGINAL PR DESCRIPTION:
Contingent on merge of huggingface/transformers#34719^ has been merged not yet released
SUMMARY:
Update run_compressed tests from decompression tests to run_comrpressed tests -> test if run_compressed True/False models generate the same output
Add decompress tests that copies attrs from the source dir path's model to the target model.
TEST PLAN:
ran the test using transformers main
must pass tests/llmcompressor/transformers/compression/test_decompress.py
and tests/llmcompressor/transformers/compression/test_run_compressed.py