add flag to not disable metrics-server

[Privatecoder]

Hi Vito,

what is the specific reason for --disable metrics-server in master_install_script.sh?

In order to see instance metrics in Rancher for example one needs to remove this line from the auto-generated k3s.service but it will be overwritten eventually (for example on upgrading the cluster nodes).

Can we implement a flag to not disable metrics-server when creating the cluster through cluster_config.yaml?

Cheers
Max

[michaelfresco]

Hi! I have added the metrics server manually:

https://kubernetes-sigs.github.io/metrics-server/

I think that some folks run a more "complete" monitoring
solution like Grafana/Prometheus. If you do that, then
you would not need the metrics server.

[Privatecoder]

Well, you could just go ahead and re-enable metrics-server by removing the --disable metrics-server in the masters k3s.service.

Also Rancher uses metrics-server to display node-metrics in the overview..

I would probably add the option to enable / disable this (along with the other disabled options) as flags in the cluster_configuration.yaml

[michaelfresco]

I think that Vito Botta settled on pretty sane defaults. You basically get a clean cluster, without too much overhead. It's not that hard to manually apply that metrics server, if you really needed. (ps. if it really bothers you, maybe create a PR and try to add this feature?)

[vitobotta]

@michaelfresco you guessed it right. The goal was to get a more "Standard" cluster, with not too much k3s specific things, so I have kept the extra software installed automatically to a minimum like CCM, CSI, autoscaler and upgrade controller. But this is a small thing that I can do with a simple setting so I will add it.

[vitobotta]

Project card ref. https://github.com/users/vitobotta/projects/4/views/1?pane=issue&itemId=59923702

[vitobotta]

This is now scheduled for v2.0.1.

v2.0.0 is going to be released probably next weekend.