Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check always-on heartbeat config before on-demand #17838

Closed
wants to merge 1 commit into from
Closed

check always-on heartbeat config before on-demand #17838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions go/vt/vttablet/tabletserver/repltracker/writer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,15 +98,15 @@ func newHeartbeatWriter(env tabletenv.Env, alias *topodatapb.TabletAlias) *heart
configType := HeartbeatConfigTypeNone
onDemandDuration := defaultOnDemandDuration
switch {
case config.ReplicationTracker.Mode == tabletenv.Heartbeat:
configType = HeartbeatConfigTypeAlways
onDemandDuration = 0
case config.ReplicationTracker.HeartbeatOnDemand > 0:
configType = HeartbeatConfigTypeOnDemand
onDemandDuration = config.ReplicationTracker.HeartbeatOnDemand
if onDemandDuration < minimalOnDemandDuration {
onDemandDuration = minimalOnDemandDuration
}
case config.ReplicationTracker.Mode == tabletenv.Heartbeat:
configType = HeartbeatConfigTypeAlways
onDemandDuration = 0
}
heartbeatInterval := config.ReplicationTracker.HeartbeatInterval
if heartbeatInterval == 0 {
Expand Down
Loading