Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VReplication: Support passing VStream filters down to MySQL #17677

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

VReplication: Support passing VStream filters down to MySQL #17677

wants to merge 9 commits into from
+171 −70

Conversation

mattlord
Copy link
Contributor

@mattlord mattlord commented Jan 31, 2025 •
edited
Loading

Description

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@mattlord
WiP
94f6471 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord
Pushdown vstream filter expressions to MySQL
03c8168 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Jan 31, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 31, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Jan 31, 2025
@mattlord
Don't use index hint if there are pushdown expressions
3632c05 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord removed the NeedsBackportReason If backport labels have been applied to a PR, a justification is required label Jan 31, 2025
@mattlord
Update unit test
1b597ec 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord force-pushed the vstream_mysql_filters branch 2 times, most recently from 3c26c03 to 2eb85e4 Compare January 31, 2025 21:30
@mattlord
Push down everything but in_keyrange
0a17436 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord force-pushed the vstream_mysql_filters branch from 2eb85e4 to 0a17436 Compare January 31, 2025 21:33
@mattlord
Fix unit tests and add another
65429c4 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Jan 31, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.78788% with 7 lines in your changes missing coverage. Please review.

Project coverage is 67.76%. Comparing base (cb7d61a) to head (3d308b3).

Files with missing lines Patch % Lines
.../vt/vttablet/tabletserver/vstreamer/rowstreamer.go 80.95% 4 Missing ⚠️
.../vt/vttablet/tabletserver/vstreamer/planbuilder.go 66.66% 3 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #17677   +/-   ##
=======================================
  Coverage   67.75%   67.76%           
=======================================
  Files        1587     1587           
  Lines      255780   255810   +30     
=======================================
+ Hits       173310   173341   +31     
+ Misses      82470    82469    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattlord
Adjust unit test for 5.7
50ca52c 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord
Tweak anlyzeWhere
a66493c 
Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
mattlord commented Jan 31, 2025
View reviewed changes
go/vt/vttablet/tabletserver/vstreamer/planbuilder.go
@@ -601,10 +610,6 @@ func (plan *Plan) analyzeWhere(vschema *localVSchema, where *sqlparser.Where) er
if !ok {
return fmt.Errorf("unexpected: %v", sqlparser.String(expr))
}
// StrVal is varbinary, we do not support varchar since we would have to implement all collation types
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This support was actually added here: #9549

@mattlord
Improve new unit test
3d308b3 
Signed-off-by: Matt Lord <mattalord@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal will be requested when the pull request is marked ready for review harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay will be requested when the pull request is marked ready for review systay is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach will be requested when the pull request is marked ready for review shlomi-noach is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps will be requested when the pull request is marked ready for review rohit-nayak-ps is a code owner

@timvaillancourt timvaillancourt Awaiting requested review from timvaillancourt timvaillancourt will be requested when the pull request is marked ready for review timvaillancourt is a code owner

@frouioui frouioui Awaiting requested review from frouioui frouioui will be requested when the pull request is marked ready for review frouioui is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 will be requested when the pull request is marked ready for review GuptaManan100 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Component: VReplication NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says Type: Feature
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@mattlord