Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integer parsing logic #17650

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Conversation

dbussink
Copy link
Contributor

We have various places where the types of what we parse and then use don't align. This is something CodeQL correctly warns about that it can lead to unexpected behavior with truncation.

This fixes those cases that CodeQL is complaining about.

Related Issue(s)

https://github.com/vitessio/vitess/security/code-scanning/793
https://github.com/vitessio/vitess/security/code-scanning/792
https://github.com/vitessio/vitess/security/code-scanning/1931
https://github.com/vitessio/vitess/security/code-scanning/1927
https://github.com/vitessio/vitess/security/code-scanning/1926
https://github.com/vitessio/vitess/security/code-scanning/1925
https://github.com/vitessio/vitess/security/code-scanning/1924
https://github.com/vitessio/vitess/security/code-scanning/1923
https://github.com/vitessio/vitess/security/code-scanning/1922
https://github.com/vitessio/vitess/security/code-scanning/1921

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

We have various places where the types of what we parse and then use
don't align. This is something CodeQL correctly warns about that it can
lead to unexpected behavior with truncation.

This fixes those cases that CodeQL is complaining about.

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Copy link
Contributor

vitess-bot bot commented Jan 29, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 29, 2025
@dbussink dbussink removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 29, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Jan 29, 2025
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 73.52941% with 9 lines in your changes missing coverage. Please review.

Project coverage is 67.74%. Comparing base (9c6c380) to head (829caf0).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtctl/grpcvtctldserver/server.go 16.66% 5 Missing ⚠️
go/vt/vttablet/tabletmanager/rpc_replication.go 0.00% 2 Missing ⚠️
go/vt/vtcombo/tablet_map.go 0.00% 1 Missing ⚠️
go/vt/vttablet/faketmclient/fake_client.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17650      +/-   ##
==========================================
- Coverage   67.76%   67.74%   -0.03%     
==========================================
  Files        1586     1586              
  Lines      255763   255767       +4     
==========================================
- Hits       173315   173264      -51     
- Misses      82448    82503      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deepthi deepthi merged commit be677ef into vitessio:main Jan 30, 2025
103 checks passed
@deepthi deepthi deleted the dbussink/fix-int-parsing branch January 30, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: General Changes throughout the code base Type: Internal Cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants