-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Views global routing #17633
base: main
Are you sure you want to change the base?
Views global routing #17633
Conversation
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17633 +/- ##
==========================================
- Coverage 67.75% 67.75% -0.01%
==========================================
Files 1587 1587
Lines 255780 255802 +22
==========================================
+ Hits 173310 173322 +12
- Misses 82470 82480 +10 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@@ -244,3 +244,13 @@ func TestRemoveSpecificKeyspace(t *testing.T) { | |||
RemoveSpecificKeyspace(stmt, "uks") | |||
require.Equal(t, "select 1 from unsharded", String(stmt)) | |||
} | |||
|
|||
// TestAddKeyspace tests the AddKeyspace function which adds the keyspace to the non-qualified table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment start doesn't match test name
Description
This PR adds support for global routing of views, allowing non-qualified views to be located seamlessly. It enables proper planning and execution for such views during query processing.
Related Issue(s)
Checklist
Deployment Notes