Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views global routing #17633

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Jan 27, 2025

Description

This PR adds support for global routing of views, allowing non-qualified views to be located seamlessly. It enables proper planning and execution for such views during query processing.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Copy link
Contributor

vitess-bot bot commented Jan 27, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 27, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Jan 27, 2025
@harshit-gangal harshit-gangal mentioned this pull request Jan 9, 2025
7 tasks
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 95.97701% with 7 lines in your changes missing coverage. Please review.

Project coverage is 67.75%. Comparing base (cb7d61a) to head (cdd2a0a).

Files with missing lines Patch % Lines
go/vt/vtgate/vindexes/vschema.go 92.50% 6 Missing ⚠️
go/vt/vtgate/semantics/vtable.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17633      +/-   ##
==========================================
- Coverage   67.75%   67.75%   -0.01%     
==========================================
  Files        1587     1587              
  Lines      255780   255802      +22     
==========================================
+ Hits       173310   173322      +12     
- Misses      82470    82480      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving and removed NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Jan 27, 2025
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
systay and others added 2 commits January 29, 2025 10:01
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@@ -244,3 +244,13 @@ func TestRemoveSpecificKeyspace(t *testing.T) {
RemoveSpecificKeyspace(stmt, "uks")
require.Equal(t, "select 1 from unsharded", String(stmt))
}

// TestAddKeyspace tests the AddKeyspace function which adds the keyspace to the non-qualified table.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment start doesn't match test name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants