Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference docstrings at AIAssistant #100

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Reference docstrings at AIAssistant #100

merged 4 commits into from
Jun 20, 2024

Conversation

fjsj
Copy link
Member

@fjsj fjsj commented Jun 19, 2024

Partial work for #81

Still have to integrate that with mkdocs. Will do in another PR.

if any_item:
return any_item.imdb_url

return super().run_as_tool(message, **kwargs)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped that because it was one more method to document, and this can now be done by overriding run. Also, I don't think this was working, because the other assistant was using this one like IMDB URL for The Matrix instead of The Matrix directly.

Copy link
Contributor

@amandasavluchinske amandasavluchinske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few small fixes.

django_ai_assistant/helpers/assistants.py Outdated Show resolved Hide resolved
django_ai_assistant/helpers/assistants.py Outdated Show resolved Hide resolved
django_ai_assistant/helpers/assistants.py Show resolved Hide resolved
Co-authored-by: Amanda Savluchinske <amandasavluchinske@gmail.com>
fjsj and others added 2 commits June 20, 2024 09:43
Co-authored-by: Pamella Bezerra <pamella@vinta.com.br>
@fjsj fjsj requested a review from pamella June 20, 2024 12:44
Copy link
Collaborator

@pamella pamella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pamella pamella merged commit 53d01b4 into main Jun 20, 2024
6 checks passed
@pamella pamella deleted the feat/ref-docs branch June 20, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants