-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference docstrings at AIAssistant #100
Conversation
if any_item: | ||
return any_item.imdb_url | ||
|
||
return super().run_as_tool(message, **kwargs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropped that because it was one more method to document, and this can now be done by overriding run. Also, I don't think this was working, because the other assistant was using this one like IMDB URL for The Matrix
instead of The Matrix
directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few small fixes.
Co-authored-by: Amanda Savluchinske <amandasavluchinske@gmail.com>
Co-authored-by: Pamella Bezerra <pamella@vinta.com.br>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Partial work for #81
Still have to integrate that with mkdocs. Will do in another PR.