Implement and document updateThread in useThreadList

vintasoftware · Oct 3, 2024 · d7c91ab · d7c91ab
1 parent 714b4d8
commit d7c91ab
Show file tree

Hide file tree

Showing 4 changed files with 106 additions and 2 deletions.
diff --git a/django_ai_assistant/helpers/use_cases.py b/django_ai_assistant/helpers/use_cases.py
@@ -206,7 +206,7 @@ def get_threads(
             If empty or None, all threads for the user are returned.
         request (HttpRequest | None): Current request, if any
     Returns:
-        list[Thread]: QuerySet of Thread model instances
+        list[Thread]: List of thread model instances
     """
     threads = Thread.objects.filter(created_by=user)
 

diff --git a/docs/frontend.md b/docs/frontend.md
@@ -106,7 +106,7 @@ Get a thread by ID.
 
 ### `aiUpdateThread`  
 Update a thread by ID.  
-**Param:** `{ threadId: string, requestBody: { name: string } }`  
+**Param:** `{ threadId: string, requestBody: { name: string, assistant_id: string } }`  
 **Return:** a `Promise` that resolves to a `Thread`.
 
 ### `aiDeleteThread`  
@@ -198,9 +198,11 @@ export function MyComponent() {
         threads,
         fetchThreads,
         createThread,
+        updateThread,
         deleteThread,
         loadingFetchThreads,
         loadingCreateThread,
+        loadingUpdateThread,
         loadingDeleteThread
     } = useThreadList();
     // ...

diff --git a/frontend/src/hooks/useThreadList.ts b/frontend/src/hooks/useThreadList.ts
@@ -3,6 +3,7 @@ import { useState } from "react";
 import {
   Thread,
   aiCreateThread,
+  aiUpdateThread,
   aiDeleteThread,
   aiListThreads,
 } from "../client";
@@ -17,6 +18,8 @@ export function useThreadList({ assistantId }: { assistantId?: string } = {}) {
     useState<boolean>(false);
   const [loadingCreateThread, setLoadingCreateThread] =
     useState<boolean>(false);
+  const [loadingUpdateThread, setLoadingUpdateThread] =
+    useState<boolean>(false);
   const [loadingDeleteThread, setLoadingDeleteThread] =
     useState<boolean>(false);
 
@@ -57,6 +60,33 @@ export function useThreadList({ assistantId }: { assistantId?: string } = {}) {
     [fetchThreads, assistantId]
   );
 
+  /**
+   * Updates a thread.
+   *
+   * @param threadId The ID of the thread to update.
+   * @param name The new name of the thread.
+   * @param shouldUpdateAssistantId If true, the assistant ID will be updated.
+   * @returns A promise that resolves with the updated thread.
+   */
+  const updateThread = useCallback(
+    async ({ threadId, name, shouldUpdateAssistantId }: { threadId: string, name: string, shouldUpdateAssistantId: boolean }): Promise<Thread> => {
+      try {
+        setLoadingUpdateThread(true);
+        const thread = await aiUpdateThread({
+          threadId, requestBody: {
+            name,
+            assistant_id: shouldUpdateAssistantId ? assistantId : undefined,
+          }
+        });
+        await fetchThreads();
+        return thread;
+      } finally {
+        setLoadingUpdateThread(false);
+      }
+    },
+    [fetchThreads, assistantId]
+  );
+
   /**
    * Deletes a thread.
    *
@@ -84,6 +114,10 @@ export function useThreadList({ assistantId }: { assistantId?: string } = {}) {
      * Function to create a new thread.
      */
     createThread,
+    /**
+     * Function to update a thread.
+     */
+    updateThread,
     /**
      * Function to delete a thread.
      */
@@ -100,6 +134,10 @@ export function useThreadList({ assistantId }: { assistantId?: string } = {}) {
      * Loading state of the create operation.
      */
     loadingCreateThread,
+    /**
+     * Loading state of the update operation.
+     */
+    loadingUpdateThread,
     /**
      * Loading state of the delete operation.
      */

diff --git a/frontend/tests/useThreadList.test.ts b/frontend/tests/useThreadList.test.ts
@@ -2,6 +2,7 @@ import { act, renderHook } from "@testing-library/react";
 import { useThreadList } from "../src/hooks";
 import {
   aiCreateThread,
+  aiUpdateThread,
   aiDeleteThread,
   aiListThreads,
 } from "../src/client";
@@ -13,6 +14,9 @@ jest.mock("../src/client", () => ({
   aiListThreads: jest
     .fn()
     .mockImplementation(() => Promise.resolve()),
+  aiUpdateThread: jest
+    .fn()
+    .mockImplementation(() => Promise.resolve()),
   aiDeleteThread: jest
     .fn()
     .mockImplementation(() => Promise.resolve()),
@@ -221,6 +225,66 @@ describe("useThreadList", () => {
     });
   });
 
+  describe("updateThread", () => {
+    it("should update a thread and update state correctly", async () => {
+      const updatedThreadId = mockThreads[0].id;
+      const updatedThread = {
+        ...mockThreads[0],
+        name: "Updated Thread",
+      };
+      (aiListThreads as jest.Mock).mockResolvedValue([updatedThread, ...mockThreads.slice(1)]);
+      (aiUpdateThread as jest.Mock).mockResolvedValue(updatedThread);
+
+      const { result } = renderHook(() => useThreadList());
+
+      result.current.threads = mockThreads;
+
+      expect(result.current.threads).toEqual(mockThreads);
+      expect(result.current.loadingUpdateThread).toBe(false);
+
+      await act(async () => {
+        await result.current.updateThread({
+          threadId: updatedThreadId.toString(),
+          name: "Updated Thread",
+          shouldUpdateAssistantId: false,
+        });
+      });
+
+      expect(result.current.threads).toEqual([updatedThread, ...mockThreads.slice(1)]);
+      expect(result.current.loadingUpdateThread).toBe(false);
+    });
+
+    it("should update a thread with shouldUpdateAssistantId", async () => {
+      const assistantId = "test_assistant";
+      const updatedThreadId = mockThreads[0].id;
+      const updatedThread = {
+        ...mockThreads[0],
+        name: "Updated Thread",
+        assistant_id: "test_assistant",
+      };
+      (aiListThreads as jest.Mock).mockResolvedValue([updatedThread, ...mockThreads.slice(1)]);
+      (aiUpdateThread as jest.Mock).mockResolvedValue(updatedThread);
+
+      const { result } = renderHook(() => useThreadList({ assistantId: assistantId }));
+
+      result.current.threads = mockThreads;
+
+      expect(result.current.threads).toEqual(mockThreads);
+      expect(result.current.loadingUpdateThread).toBe(false);
+
+      await act(async () => {
+        await result.current.updateThread({
+          threadId: updatedThreadId.toString(),
+          name: "Updated Thread",
+          shouldUpdateAssistantId: true,
+        });
+      });
+
+      expect(result.current.threads).toEqual([updatedThread, ...mockThreads.slice(1)]);
+      expect(result.current.loadingUpdateThread).toBe(false);
+    });
+  });
+
   describe("deleteThread", () => {
     it("should delete a thread and update state correctly", async () => {
       const deletedThreadId = mockThreads[0].id;