begin handling of property hooks #11359
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a beggining for property hooks handling in Psalm
What I did is basically try to duplicate what Psalm does when it sees a class method but applied to properties that have a hook. It involve creating fake methods so that Psalm understands this can be called
It doesn't work completely yet. It seems that the MethodStorage I retrieve are not completely filled. That is preventing Psalm to analyse the hook as a method and it complains that the argument for the fake set method is unused
I'm not sure I'll work with it anytime soon. Feel free to use this as you want if you're trying to get property hooks done